Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finally: Replace .label by .getLabel() #1107

Closed
wants to merge 1 commit into from
Closed

Conversation

don-vip
Copy link
Contributor

@don-vip don-vip commented Sep 3, 2018

simon04 pushed a commit to JOSM/josm that referenced this pull request Sep 4, 2018
floscher pushed a commit to floscher/josm that referenced this pull request Sep 5, 2018
@don-vip don-vip mentioned this pull request Sep 5, 2018
@floscher
Copy link

I also encountered this exception in https://gitlab.com/JOSM/Mapillary/-/jobs/107783724

@don-vip
Copy link
Contributor Author

don-vip commented Oct 13, 2018

@floscher you can use JOSM patched version of error_prone

@volmus
Copy link

volmus commented Apr 3, 2019

@cushon
Is this going to be merged anytime soon?

@bgalek
Copy link

bgalek commented Apr 26, 2019

@cushon - Looking forward for this change :)

@volmus
Copy link

volmus commented Jun 4, 2019

@cpovirk @ronshapiro

@gliptak
Copy link

gliptak commented Mar 20, 2020

@graememorgan please review

Copy link

@bgalek bgalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cushon cushon self-assigned this Mar 20, 2020
nick-someone pushed a commit that referenced this pull request Mar 23, 2020
See #1106 - field removed in JDK12 as per

Fixes #1107

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=302397069
@nick-someone nick-someone mentioned this pull request Mar 23, 2020
nick-someone pushed a commit that referenced this pull request Mar 23, 2020
See #1106 - field removed in JDK12 as per

Fixes #1107

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=302397069
@don-vip don-vip deleted the jdk12 branch June 1, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants